diff --git a/dynamic_programming/house_robber.cpp b/dynamic_programming/house_robber.cpp index d9a19a8a3..79c111f83 100644 --- a/dynamic_programming/house_robber.cpp +++ b/dynamic_programming/house_robber.cpp @@ -1,11 +1,8 @@ /** * @file - * @brief Implementation of [House Robber - * Problem](https://labuladong.gitbook.io/algo-en/i.-dynamic-programming/houserobber) - * algorithm + * @brief Implementation of [House Robber Problem](https://labuladong.gitbook.io/algo-en/i.-dynamic-programming/houserobber) algorithm * @details - * Solution of House robber problem uses a dynamic programming concept that - * works in \f$O(n)\f$ time and works in \f$O(1)\f$ space. + * Solution of House robber problem uses a dynamic programming concept that works in \f$O(n)\f$ time and works in \f$O(1)\f$ space. * @author [Swastika Gupta](https://github.com/Swastyy) */ @@ -20,33 +17,30 @@ namespace dynamic_programming { /** * @namespace house_robber - * @brief Functions for the [House - * Robber](https://labuladong.gitbook.io/algo-en/i.-dynamic-programming/houserobber) + * @brief Functions for the [House Robber](https://labuladong.gitbook.io/algo-en/i.-dynamic-programming/houserobber) * algorithm */ namespace house_robber { /** - * @brief The main function implements house robber algorithm using dynamic - * programming + * @brief The main function implements house robber algorithm using dynamic programming * @param money array containing money in the ith house * @param n size of array * @returns maximum amount of money that can be robbed */ -std::uint32_t houseRobber(const std::vector &money, const int &n) { +std::uint32_t houseRobber(const std::vector &money, const uint32_t &n) { if (n == 0) { // if there is no house return 0; } if (n == 1) { // if there is only one house return money[0]; } - if (n == 2) { // if there are two houses, one with the maximum amount of - // money will be robbed + if (n == 2) { // if there are two houses, one with the maximum amount of money will be robbed return std::max(money[0], money[1]); } - int max_value = 0; // contains maximum stolen value at the end - int value1 = money[0]; - int value2 = std::max(money[0], money[1]); - for (int i = 2; i < n; i++) { + uint32_t max_value = 0; // contains maximum stolen value at the end + uint32_t value1 = money[0]; + uint32_t value2 = std::max(money[0], money[1]); + for (uint32_t i = 2; i < n; i++) { max_value = std::max(money[i] + value1, value2); value1 = value2; value2 = max_value; @@ -66,39 +60,28 @@ static void test() { // [1, 2, 3, 1] return 4 std::vector array1 = {1, 2, 3, 1}; std::cout << "Test 1... "; - assert( - dynamic_programming::house_robber::houseRobber(array1, array1.size()) == - 4); // here the two non-adjacent houses that are robbed are first and - // third with total sum money as 4 + assert(dynamic_programming::house_robber::houseRobber(array1, array1.size()) == 4); // here the two non-adjacent houses that are robbed are first and third with total sum money as 4 std::cout << "passed" << std::endl; // Test 2 // [6, 7, 1, 3, 8, 2, 4] return 19 std::vector array2 = {6, 7, 1, 3, 8, 2, 4}; std::cout << "Test 2... "; - assert( - dynamic_programming::house_robber::houseRobber(array2, array2.size()) == - 19); // here the four non-adjacent houses that are robbed are first, - // third, fifth and seventh with total sum money as 19 + assert(dynamic_programming::house_robber::houseRobber(array2, array2.size()) == 19); // here the four non-adjacent houses that are robbed are first, third, fifth and seventh with total sum money as 19 std::cout << "passed" << std::endl; // Test 3 // [] return 0 std::vector array3 = {}; std::cout << "Test 3... "; - assert( - dynamic_programming::house_robber::houseRobber(array3, array3.size()) == - 0); // since there is no house no money can be robbed + assert(dynamic_programming::house_robber::houseRobber(array3, array3.size()) == 0); // since there is no house no money can be robbed std::cout << "passed" << std::endl; // Test 4 // [2,7,9,3,1] return 12 std::vector array4 = {2, 7, 9, 3, 1}; std::cout << "Test 4... "; - assert( - dynamic_programming::house_robber::houseRobber(array4, array4.size()) == - 12); // here the three non-adjacent houses that are robbed are first, - // third and fifth with total sum money as 12 + assert(dynamic_programming::house_robber::houseRobber(array4, array4.size()) == 12); // here the three non-adjacent houses that are robbed are first, third and fifth with total sum money as 12 std::cout << "passed" << std::endl; }