fix: max length of arrays and coding style (#1614)

* Fixed array max length and coding style

Max length of arrays was previously an absurdly high integer, instead implemented a numerical upper bound using log2 (max depth of seg tree being logn). Removed `using namespace std;` and `typedef long long ll;` and other competitive coding practices. Added input prompts.

* Fixed remaining clang-tidy warnings

* Replaced reference parameters with const & or *

* Self-tests and documentation

* Improved documentation

* Added author names

Co-authored-by: David Leal <halfpacho@gmail.com>
This commit is contained in:
Soham Roy 2021-10-18 20:38:42 +05:30 committed by GitHub
parent 72e88b30cd
commit 61cbc630c3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -1,79 +1,218 @@
//#include <bits/stdc++.h> /**
#incldue < iostream > * @file
#define MAX 4000000 * @brief Implementation of [Segment Tree]
using namespace std; * (https://en.wikipedia.org/wiki/Segment_tree) data structure
typedef long long ll; *
void ConsTree(ll arr[], ll segtree[], ll low, ll high, ll pos) { * @details
* A segment tree, also known as a statistic tree, is a tree data structure used
* for storing information about intervals, or segments. Its classical version
* allows querying which of the stored segments contain a given point, but our
* modification allows us to perform (query) any binary operation on any range
* in the array in O(logN) time. Here, we have used addition (+).
* For range updates, we have used lazy propagation.
*
* * Space Complexity : O(NlogN) \n
* * Build Time Complexity : O(NlogN) \n
* * Query Time Complexity : O(logN) \n
*
* @author [Madhav Gaba](https://github.com/madhavgaba)
* @author [Soham Roy](https://github.com/sohamroy19)
*/
#include <cassert> /// for assert
#include <cmath> /// for log2
#include <iostream> /// for IO operations
#include <vector> /// for std::vector
/**
* @brief Constructs the initial segment tree
*
* @param arr input to construct the tree out of
* @param segtree the segment tree
* @param low inclusive lowest index of arr to begin at
* @param high inclusive highest index of arr to end at
* @param pos index of segtree to fill (eg. root node)
* @returns void
*/
void ConsTree(const std::vector<int64_t> &arr, std::vector<int64_t> *segtree,
uint64_t low, uint64_t high, uint64_t pos) {
if (low == high) { if (low == high) {
segtree[pos] = arr[low]; (*segtree)[pos] = arr[low];
return; return;
} }
ll mid = (low + high) / 2;
uint64_t mid = (low + high) / 2;
ConsTree(arr, segtree, low, mid, 2 * pos + 1); ConsTree(arr, segtree, low, mid, 2 * pos + 1);
ConsTree(arr, segtree, mid + 1, high, 2 * pos + 2); ConsTree(arr, segtree, mid + 1, high, 2 * pos + 2);
segtree[pos] = segtree[2 * pos + 1] + segtree[2 * pos + 2]; (*segtree)[pos] = (*segtree)[2 * pos + 1] + (*segtree)[2 * pos + 2];
} }
ll query(ll segtree[], ll lazy[], ll qlow, ll qhigh, ll low, ll high, ll pos) {
if (low > high) /**
* @brief Returns the sum of all elements in a range
*
* @param segtree the segment tree
* @param lazy for lazy propagation
* @param qlow lower index of the required query
* @param qhigh higher index of the required query
* @param low lower index of query for this function call
* @param high higher index of query for this function call
* @param pos index of segtree to consider (eg. root node)
* @return result of the range query for this function call
*/
int64_t query(std::vector<int64_t> *segtree, std::vector<int64_t> *lazy,
uint64_t qlow, uint64_t qhigh, uint64_t low, uint64_t high,
uint64_t pos) {
if (low > high || qlow > high || low > qhigh) {
return 0; return 0;
if (qlow > high || qhigh < low) }
return 0;
if (lazy[pos] != 0) { if ((*lazy)[pos] != 0) {
segtree[pos] += lazy[pos] * (high - low + 1); (*segtree)[pos] += (*lazy)[pos] * (high - low + 1);
if (low != high) { if (low != high) {
lazy[2 * pos + 1] += lazy[pos]; (*lazy)[2 * pos + 1] += (*lazy)[pos];
lazy[2 * pos + 2] += lazy[pos]; (*lazy)[2 * pos + 2] += (*lazy)[pos];
} }
lazy[pos] = 0; (*lazy)[pos] = 0;
} }
if (qlow <= low && qhigh >= high)
return segtree[pos]; if (qlow <= low && qhigh >= high) {
ll mid = (low + high) / 2; return (*segtree)[pos];
}
uint64_t mid = (low + high) / 2;
return query(segtree, lazy, qlow, qhigh, low, mid, 2 * pos + 1) + return query(segtree, lazy, qlow, qhigh, low, mid, 2 * pos + 1) +
query(segtree, lazy, qlow, qhigh, mid + 1, high, 2 * pos + 2); query(segtree, lazy, qlow, qhigh, mid + 1, high, 2 * pos + 2);
} }
void update(ll segtree[], ll lazy[], ll start, ll end, ll delta, ll low,
ll high, ll pos) { /**
if (low > high) * @brief Updates a range of the segment tree
*
* @param segtree the segment tree
* @param lazy for lazy propagation
* @param start lower index of the required query
* @param end higher index of the required query
* @param delta integer to add to each element of the range
* @param low lower index of query for this function call
* @param high higher index of query for this function call
* @param pos index of segtree to consider (eg. root node)
* @returns void
*/
void update(std::vector<int64_t> *segtree, std::vector<int64_t> *lazy,
int64_t start, int64_t end, int64_t delta, uint64_t low,
uint64_t high, uint64_t pos) {
if (low > high) {
return; return;
if (lazy[pos] != 0) { }
segtree[pos] += lazy[pos] * (high - low + 1);
if ((*lazy)[pos] != 0) {
(*segtree)[pos] += (*lazy)[pos] * (high - low + 1);
if (low != high) { if (low != high) {
lazy[2 * pos + 1] += lazy[pos]; (*lazy)[2 * pos + 1] += (*lazy)[pos];
lazy[2 * pos + 2] += lazy[pos]; (*lazy)[2 * pos + 2] += (*lazy)[pos];
} }
lazy[pos] = 0; (*lazy)[pos] = 0;
} }
if (start > high || end < low)
if (start > high || end < low) {
return; return;
}
if (start <= low && end >= high) { if (start <= low && end >= high) {
segtree[pos] += delta * (high - low + 1); (*segtree)[pos] += delta * (high - low + 1);
if (low != high) { if (low != high) {
lazy[2 * pos + 1] += delta; (*lazy)[2 * pos + 1] += delta;
lazy[2 * pos + 2] += delta; (*lazy)[2 * pos + 2] += delta;
} }
return; return;
} }
ll mid = (low + high) / 2;
uint64_t mid = (low + high) / 2;
update(segtree, lazy, start, end, delta, low, mid, 2 * pos + 1); update(segtree, lazy, start, end, delta, low, mid, 2 * pos + 1);
update(segtree, lazy, start, end, delta, mid + 1, high, 2 * pos + 2); update(segtree, lazy, start, end, delta, mid + 1, high, 2 * pos + 2);
segtree[pos] = segtree[2 * pos + 1] + segtree[2 * pos + 2]; (*segtree)[pos] = (*segtree)[2 * pos + 1] + (*segtree)[2 * pos + 2];
} }
/**
* @brief Self-test implementation
*
* @returns void
*/
static void test() {
int64_t max = static_cast<int64_t>(2 * pow(2, ceil(log2(7))) - 1);
assert(max == 15);
std::vector<int64_t> arr{1, 2, 3, 4, 5, 6, 7}, lazy(max), segtree(max);
ConsTree(arr, &segtree, 0, 7 - 1, 0);
assert(query(&segtree, &lazy, 1, 5, 0, 7 - 1, 0) == 2 + 3 + 4 + 5 + 6);
update(&segtree, &lazy, 2, 4, 1, 0, 7 - 1, 0);
assert(query(&segtree, &lazy, 1, 5, 0, 7 - 1, 0) == 2 + 4 + 5 + 6 + 6);
update(&segtree, &lazy, 0, 6, -2, 0, 7 - 1, 0);
assert(query(&segtree, &lazy, 0, 4, 0, 7 - 1, 0) == -1 + 0 + 2 + 3 + 4);
}
/**
* @brief Main function
*
* @return 0 on exit
*/
int main() { int main() {
ll n, c; test(); // run self-test implementations
scanf("%lld %lld", &n, &c);
ll arr[n] = {0}, p, q, v, choice; std::cout << "Enter number of elements: ";
ll segtree[MAX], lazy[MAX] = {0};
ConsTree(arr, segtree, 0, n - 1, 0); uint64_t n = 0;
while (c--) { std::cin >> n;
scanf("%lld", &choice);
if (choice == 0) { uint64_t max = static_cast<uint64_t>(2 * pow(2, ceil(log2(n))) - 1);
scanf("%lld %lld %lld", &p, &q, &v); std::vector<int64_t> arr(n), lazy(max), segtree(max);
update(segtree, lazy, p - 1, q - 1, v, 0, n - 1, 0);
} else { int choice = 0;
scanf("%lld %lld", &p, &q); std::cout << "\nDo you wish to enter each number?:\n"
printf("%lld\n", query(segtree, lazy, p - 1, q - 1, 0, n - 1, 0)); "1: Yes\n"
"0: No (default initialize them to 0)\n";
std::cin >> choice;
if (choice == 1) {
std::cout << "Enter " << n << " numbers:\n";
for (int i = 1; i <= n; i++) {
std::cout << i << ": ";
std::cin >> arr[i];
} }
} }
ConsTree(arr, &segtree, 0, n - 1, 0);
do {
std::cout << "\nMake your choice:\n"
"1: Range update (input)\n"
"2: Range query (output)\n"
"0: Exit\n";
std::cin >> choice;
if (choice == 1) {
std::cout << "Enter 1-indexed lower bound, upper bound & value:\n";
uint64_t p = 1, q = 1, v = 0;
std::cin >> p >> q >> v;
update(&segtree, &lazy, p - 1, q - 1, v, 0, n - 1, 0);
} else if (choice == 2) {
std::cout << "Enter 1-indexed lower bound & upper bound:\n";
uint64_t p = 1, q = 1;
std::cin >> p >> q;
std::cout << query(&segtree, &lazy, p - 1, q - 1, 0, n - 1, 0);
std::cout << "\n";
}
} while (choice > 0);
return 0; return 0;
} }