Commit Graph

3 Commits

Author SHA1 Message Date
Sujal Gupta
2d492834b1
feat: update CMake version to 3.26.4 (#2486)
* update cmake version

* clang-format and clang-tidy fixes for 402c5627

---------

Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: github-actions[bot] <github-actions@users.noreply.github.com>
2023-06-16 16:08:45 -06:00
ewd00010
5704841875
[feat/docs/fix]: fit check_factorial.cpp to guidelines (#2466)
* Quality of life update

FIX: added namespace math, changed for a weird for loop to a while loop with a better conditional and I initiation
CHORE: Cleaned documentation and added details plus links. removed the invalid cout lines in test for one line.

* Update math/check_factorial.cpp

Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>

* Update math/check_factorial.cpp

Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>

* Update math/check_factorial.cpp

Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>

* Update math/check_factorial.cpp

Co-authored-by: David Leal <halfpacho@gmail.com>

* Update math/check_factorial.cpp

Co-authored-by: David Leal <halfpacho@gmail.com>

* Update math/check_factorial.cpp

Co-authored-by: David Leal <halfpacho@gmail.com>

* Update math/check_factorial.cpp

Co-authored-by: David Leal <halfpacho@gmail.com>

* Update math/check_factorial.cpp

Co-authored-by: David Leal <halfpacho@gmail.com>

* chore: apply suggestions from code review

* Updated last return in is_factorial

* Update math/check_factorial.cpp

Co-authored-by: David Leal <halfpacho@gmail.com>

---------

Co-authored-by: realstealthninja <68815218+realstealthninja@users.noreply.github.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
2023-06-16 15:25:06 -06:00
Divyajyoti Ukirde
04e0acc3cf
feat: added check_factorial (#1155)
* feat: added check_factorial

* updating DIRECTORY.md

* feat: added check_factorial

* review changes

* review changes

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
2020-10-05 08:52:27 -04:00