mirror of
https://hub.njuu.cf/TheAlgorithms/Python.git
synced 2023-10-11 13:06:12 +08:00
a03b739d23
* Fix insertion fail in ["*X", "*XX"] cases
Consider a word, and a copy of that word, but with the last letter repeating twice. (e.g., ["ABC", "ABCC"])
When adding the second word's last letter, it only compares the previous word's prefix—the last letter of the word already in the Radix Tree: 'C'—and the letter to be added—the last letter of the word we're currently adding: 'C'. So it wrongly passes the "Case 1" check, marks the current node as a leaf node when it already was, then returns when there's still one more letter to add.
The issue arises because `prefix` includes the letter of the node itself. (e.g., `nodes: {'C' : RadixNode()}, is_leaf: True, prefix: 'C'`) It can be easily fixed by simply adding the `is_leaf` check, asking if there are more letters to be added.
- Test Case: `"A AA AAA AAAA"`
- Fixed correct output:
```
Words: ['A', 'AA', 'AAA', 'AAAA']
Tree:
- A (leaf)
-- A (leaf)
--- A (leaf)
---- A (leaf)
```
- Current incorrect output:
```
Words: ['A', 'AA', 'AAA', 'AAAA']
Tree:
- A (leaf)
-- AA (leaf)
--- A (leaf)
```
*N.B.* This passed test cases for [Croatian Open Competition in Informatics 2012/2013 Contest #3 Task 5 HERKABE](https://hsin.hr/coci/archive/2012_2013/)
* Add a doctest for previous fix
* improve doctest readability
|
||
|---|---|---|
| .github | ||
| .vscode | ||
| arithmetic_analysis | ||
| audio_filters | ||
| backtracking | ||
| bit_manipulation | ||
| blockchain | ||
| boolean_algebra | ||
| cellular_automata | ||
| ciphers | ||
| compression | ||
| computer_vision | ||
| conversions | ||
| data_structures | ||
| digital_image_processing | ||
| divide_and_conquer | ||
| dynamic_programming | ||
| electronics | ||
| file_transfer | ||
| financial | ||
| fractals | ||
| fuzzy_logic | ||
| genetic_algorithm | ||
| geodesy | ||
| graphics | ||
| graphs | ||
| greedy_methods | ||
| hashes | ||
| knapsack | ||
| linear_algebra | ||
| linear_programming | ||
| machine_learning | ||
| maths | ||
| matrix | ||
| networking_flow | ||
| neural_network | ||
| other | ||
| physics | ||
| project_euler | ||
| quantum | ||
| scheduling | ||
| scripts | ||
| searches | ||
| sorts | ||
| strings | ||
| web_programming | ||
| .gitattributes | ||
| .gitignore | ||
| .gitpod.yml | ||
| .pre-commit-config.yaml | ||
| CONTRIBUTING.md | ||
| DIRECTORY.md | ||
| LICENSE.md | ||
| pyproject.toml | ||
| README.md | ||
| requirements.txt | ||
Implementations are for learning purposes only. They may be less efficient than the implementations in the Python standard library. Use them at your discretion.
Getting Started
Read through our Contribution Guidelines before you contribute.
Community Channels
We are on Discord and Gitter! Community channels are a great way for you to ask questions and get help. Please join us!
List of Algorithms
See our directory for easier navigation and a better overview of the project.